Re: [PATCH] staging/fwserial: use correct vendor/version IDs

From: Peter Hurley
Date: Mon Feb 02 2015 - 17:08:39 EST


On 01/28/2015 03:07 PM, Clemens Ladisch wrote:
> The driver was using the vendor ID 0xd00d1e from the FireWire core.
> However, this ID was not registered, and invalid.
>
> Instead, use the vendor/version IDs that now are officially assigned to
> firewire-serial:
> https://ieee1394.wiki.kernel.org/index.php/IEEE_OUI_Assignments

That's great that we have official OUIs now, but I have to NACK this
patch as is.

The problem is a host with the old OUIs will not recognize a remote
unit with the new OUIs, and vice versa.

Even though the new ids could be added to the unit driver's id_table,
(which would let hosts with the new OUI connect to either OUI remote),
it wouldn't let 3.19- hosts connect to 3.20+ hosts.

Regards,
Peter Hurley




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/