Re: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache

[Jaegeuk Kim]

On Mon, Feb 02, 2015 at 10:59:28AM +0800, Chao Yu wrote:
> Hi all,
> 
> > -----Original Message-----
> > From: Chao Yu [mailto:chao2.yu@xxxxxxxxxxx]
> > Sent: Monday, January 26, 2015 1:52 PM
> > To: Jaegeuk Kim; Changman Lee
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> > Subject: [f2fs-dev] [PATCH v2 06/10] f2fs: add core functions for rb-tree extent cache
> > 
> > This patch adds core functions including slab cache init function and
> > init/lookup/update/shrink/destroy function for rb-tree based extent cache.
> > 
> > Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail
> > design and implementation of extent cache.
> > 
> > Todo:
> >  * add a cached_ei into struct extent_tree for a quick recent cache.
> >  * register rb-based extent cache shrink with mm shrink interface.
> >  * disable dir inode's extent cache.
> > 
> > v2:
> >  o move set_extent_info and __is_{extent,back,front}_mergeable into f2fs.h.
> >  o introduce __{attach,detach}_extent_node for code readability.
> >  o use f2fs_kmem_cache_alloc/f2fs_radix_tree_insert for code readability.
> >  o fix some coding style and typo issues.
> >  o get rid of node/tree count stat in f2fs_{shrink,destroy}_extent_tree.
> > 
> 
> There is an obviously bug in this patch, with it we will encounter an oops easily,
> My mistaken, Please ignore this patch set, sorry for the noise. :(
> 
> I will send a v3 later.

Hi Chao,

Okay, then I'll remove all the patches in this series from my testing branch.
Note that, I confirmed the patches till 05/10 have no problem.

Thanks,

> 
> Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/