Re: [PATCH 1/2] f2fs: don't trigger recovery for normal umount image
From: Jaegeuk Kim
Date: Mon Feb 02 2015 - 18:31:46 EST
Hi Chao,
On Sat, Jan 31, 2015 at 04:59:49PM +0800, Chao Yu wrote:
> Our recovery option is on by default, so we will try to recover data for
> a normally umounted image when mounting it, but no data will be recovered.
>
> So it'd be better to skip the recovery for above condition.
No.
We should consider the existing UMOUNT flag written by old f2fs.
Thanks,
>
> Signed-off-by: Chao Yu <chao2.yu@xxxxxxxxxxx>
> ---
> fs/f2fs/recovery.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index 188a034..c80c286 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -500,6 +500,9 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
> int err;
> bool need_writecp = false;
>
> + if (is_set_ckpt_flags(sbi->ckpt, CP_UMOUNT_FLAG))
> + return 0;
> +
> fsync_entry_slab = f2fs_kmem_cache_create("f2fs_fsync_inode_entry",
> sizeof(struct fsync_inode_entry));
> if (!fsync_entry_slab)
> --
> 2.2.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/