Re: [PATCH v5 0/2] ARM: mediatek: Add watchdog driver

From: Wim Van Sebroeck
Date: Mon Feb 02 2015 - 19:02:34 EST


Hi Matthias,

> Mediatek SoCs have a watchdog driver. This patch set adds driver and DTS
> binding. The driver also implements a restart handler to reboot the SoC.
>
> Changes for v5:
> - add newline in dev_info message
> - add tested-by and reviewed-by
>
> Changes for v4:
> - fix indentation errors
> - delete unused include
> - reorganize while loop to eliminate code duplication
> - eliminate indirection to watchdog_device structure
> - delete unnecessary brackets
>
> Changes for v3:
> - fix based on file name
> - fix style problems
> - fix error return value and warning message
> - delete unnecessary watchdog_set_drvdata
> - delete unused variable
>
> Changes for v2:
> - we don't need to have the watchdog enabled to do a software reset
> - disable dual mode and irq mode when starting the watchdog
> - update commit message to name the SoCs the driver supports
>
>
> Matthias Brugger (2):
> watchdog: Add driver for Mediatek watchdog
> ARM: mediatek: dts: Add bindings for watchdog
>
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 13 ++
> drivers/watchdog/Kconfig | 10 +
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/mtk_wdt.c | 252 +++++++++++++++++++++
> 4 files changed, 276 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> create mode 100644 drivers/watchdog/mtk_wdt.c
>

Both patches have been added to linux-watchdog-next.
I made a small change: I removed the .owner field in the platform_driver struct.
This is now normally set by the core.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/