Re: [PATCH 1/3] ARM: OMAP2+: gpmc: Fix writing in gpmc_cs_set_memconf

[Roger Quadros]

On 02/02/15 19:08, Tony Lindgren wrote:
> * Roger Quadros <rogerq@xxxxxx> [150126 01:38]:
>> On 24/01/15 22:28, Semen Protsenko wrote:
>>> Some GPMC_CONFIG7 register bits marked as "RESERVED", means they
>>> shouldn't be overwritten. A typical approach to handle such bits called
>>> "Read-Modify-Write". Writing procedure used in gpmc_cs_set_memconf()
>>> utilizes RMW technique, but implemented incorrectly. Due to obvious typo
>>> in code read register value is being rewritten by another value, which
>>> leads to loss of read RESERVED bits. This patch fixes this.
>>>
>>> While at it, replace magic numbers with named constants to improve code
>>> readability.
>>>
>>> Signed-off-by: Semen Protsenko <semen.protsenko@xxxxxxxxxxxxxxx>
>>
>> This is much nicer.
>>
>> Acked-by: Roger Quadros <rogerq@xxxxxx>
> 
> Roger will queue this so:
> 
> Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
Thanks.
Patches 1 and 2 queued for v3.21.
https://github.com/rogerq/linux/tree/for-v3.21/gpmc-omap

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/