Re: [PATCH v13 5/6] clkdev: Export clk_register_clkdev

[Andy Shevchenko]

On Fri, Jan 23, 2015 at 1:03 PM, Tomeu Vizoso
<tomeu.vizoso@xxxxxxxxxxxxx> wrote:
> So it can be used from modules such as clk-test.ko.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
> Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Sorry for late answer, but this is useless.

We have to provide the way how to get the allocated clk_lookup.
Otherwise you have no way but memory leak at the ->remove() stage.

(By the way I used to have the exact patch locally, that's why
discovered the change in upsteam)

> ---
>  drivers/clk/clkdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index 901d242..29a1ab7 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -377,6 +377,7 @@ int clk_register_clkdev(struct clk *clk, const char *con_id,
>
>         return 0;
>  }
> +EXPORT_SYMBOL(clk_register_clkdev);
>
>  /**
>   * clk_register_clkdevs - register a set of clk_lookup for a struct clk
> --
> 1.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/