Re: [PATCH] spi: img-spfi: same edge bit set to double spfi speeds

[Andrew Bresticker]

Hi Sifan,

On Tue, Feb 3, 2015 at 9:46 AM, Sifan Naeem <sifan.naeem@xxxxxxxxxx> wrote:
> Setting the same edge bit is required for operating at full bitrate
> programmed into the SPFI control register. Without this bit set the
> max operating bitrate supported would be half the maximum bitrate
> supported by the img-spfi block.
> It's safe to set this bit for all transactions.
>
> Signed-off-by: Sifan Naeem <sifan.naeem@xxxxxxxxxx>

> @@ -435,6 +436,9 @@ static void img_spfi_config(struct spi_master *master, struct spi_device *spi,
>                 val |= SPFI_CONTROL_CONTINUE;
>         spfi_writel(spfi, val, SPFI_CONTROL);
>
> +       /* Double the transfer speed by setting Same Edge. */

I'm not sure a comment here is totally necessary, but if you do want
one, I don't think "Double the transfer speed" is the best way to put
this.  Something explaining what the SE bit does and that failing to
set it results in us operating at half the specified bitrate would be
more useful.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/