Re: [PATCH v3] Add ARCH_MIGHT_HAVE_VGA_CONSOLE

[Arnd Bergmann]

On Wednesday 04 February 2015 15:03:32 Yoshinori Sato wrote:
> @@ -2,14 +2,14 @@
>  # Video configuration
>  #
>  
> +config ARCH_MIGHT_HAVE_VGA_CONSOLE
> +        bool
> +
>  menu "Console display driver support"
>  
> 

I just noticed one more problem: The file that you add the option to is
conditional on CONFIG_VT, and that option is user-selectable. If
VT is disabled, you will get a warning from architectures that select
the symbol.

I think you should move the statement above into drivers/video/Kconfig,
outside of the 'if VT'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/