Re: [PATCH] net: core/dev: fix sparse warning

[Lad, Prabhakar]

On Wed, Feb 4, 2015 at 12:41 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Wed, 2015-02-04 at 12:25 +0000, Lad Prabhakar wrote:
>> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
>>
>> this patch fixes following sparse warning:
>> net/core/dev.c: In function 'validate_xmit_skb_list':
>> net/core/dev.c:2720: warning: 'tail' may be used uninitialized in this function
>>
>> Although its a false positive, as head is assigned to NULL in the
>> beginning, due which later in the loop tail is assigned to skb->prev.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>> ---
>>  net/core/dev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/core/dev.c b/net/core/dev.c
>> index 8ce0d1a..c736467 100644
>> --- a/net/core/dev.c
>> +++ b/net/core/dev.c
>> @@ -2717,7 +2717,7 @@ out_null:
>>
>>  struct sk_buff *validate_xmit_skb_list(struct sk_buff *skb, struct net_device *dev)
>>  {
>> -     struct sk_buff *next, *head = NULL, *tail;
>> +     struct sk_buff *next, *head = NULL, *tail = NULL;
>>
>>       for (; skb != NULL; skb = next) {
>>               next = skb->next;
>
> Which gcc/sparse versions are you using ?
>
I tried it on gcc 4.3.3 and sparse with 0.4.5-rc1 version.

Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/