Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

From: Laurent Pinchart
Date: Wed Feb 04 2015 - 08:50:00 EST


Hi Sergei,

On Wednesday 04 February 2015 16:31:29 Sergei Shtylyov wrote:
> On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote:
> > Anyone may call clk_round_rate() with a zero rate value, so we have to
> > protect against that.
>
> Shouldn't this be checked and fixed up in clk_round_rate() then?

Not all implementations need to divide by the requested rate, so I don't think
a check in the core is the best solution.

> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/