RE: mips: Re-introduce copy_user_page

[Wilcox, Matthew R]

There is no 'struct page' for the source of this data.  We have a kernel address for it; that's all.

-----Original Message-----
From: Leonid Yegoshin [mailto:Leonid.Yegoshin@xxxxxxxxxx] 
Sent: Tuesday, February 03, 2015 10:40 AM
To: Guenter Roeck; Ralf Baechle
Cc: linux-mips@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Atsushi Nemoto; Wilcox, Matthew R
Subject: Re: mips: Re-introduce copy_user_page

On 01/30/2015 09:23 PM, Guenter Roeck wrote:
> Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced
> the inline function copy_user_page for mips with an external reference,
> but neglected to introduce the actual non-inline function. Restore it.
>
> Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork")
> Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler")
> Cc: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>
> Cc: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>

Why do you use copy_user_page?
It doesn't work properly in HIGHMEM environment and it is excluded from 
MIPS because of that, I believe.

You should use copy_user_highpage() for user pages.

- Leonid.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/