Re: [PATCH_V2 25/34] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs

[Paul Bolle]

On Wed, 2015-02-04 at 15:21 +0000, Zubair Lutfullah Kakakhel wrote:
> From: Paul Burton <paul.burton@xxxxxxxxxx>
> 
> Introduce a driver suitable for use with the UARTs present in
> Ingenic jz47xx series SoCs. These are described as being ns16550
> compatible but aren't quite - they require the setting of an extra bit
> in the FCR register to enable the UART module. The serial_out
> implementation is the same as that in arch/mips/jz4740/serial.c - which
> will shortly be removed.
> 
> Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: linux-serial@xxxxxxxxxxxxxxx
> 
> ---
> V2 changes
> Removed FSF address
> Added select SERIAL_CORE_CONSOLE to fix a build error
> ---
>  drivers/tty/serial/8250/8250_jz47xx.c | 225 ++++++++++++++++++++++++++++++++++
>  drivers/tty/serial/8250/Kconfig       |   9 ++
>  drivers/tty/serial/8250/Makefile      |   1 +
>  3 files changed, 235 insertions(+)
>  create mode 100644 drivers/tty/serial/8250/8250_jz47xx.c
> 
>[...]
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 0fcbcd2..ebb298e 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -322,3 +322,12 @@ config SERIAL_8250_MT6577
>  	help
>  	  If you have a Mediatek based board and want to use the
>  	  serial port, say Y to this option. If unsure, say N.
> +
> +config SERIAL_8250_JZ47XX
> +	tristate "Support for Ingenic jz47xx series serial ports"
> +	depends on SERIAL_8250
> +	select SERIAL_EARLYCON
> +	select SERIAL_CORE_CONSOLE
> +	help
> +	  If you have a system using an Ingenic jz47xx series SoC and wish to
> +	  make use of its UARTs, say Y to this option. If unsure, say N.

Nit: should people never say M?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/