Re: [PATCH 2/3] iio: qcom-spmi-iadc: cleanup wait_for_completion return handling

[Ivan T. Ivanov]

On Wed, 2015-02-04 at 16:59 +0000, Jonathan Cameron wrote:
> On 02/02/15 08:37, Nicholas Mc Guire wrote:
> > This patch fixes two issues:
> > * return type of wait_for_completion_timeout is unsigned long not int,
> >   rather than adding a dedicated variable the wait_for_completion_timeout
> >   is moved into the condition directly
> > * the timeout of wait_for_completion_timeout is in jiffies but the value
> >   being passed was a unsigned long not converted to jiffies and thus was
> >   dependent on the HZ settings which is probably not what you want.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> Ivan, need your Ack / Reviewed-by on this one.
> 

Yes, change is correct, as explained before [1].

Acked-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>


[1] https://lkml.org/lkml/2015/1/5/409

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/