Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

[Pali RohÃr]

On Tuesday 03 February 2015 20:57:11 Pali RohÃr wrote:
> On Tuesday 03 February 2015 20:35:25 Felipe Balbi wrote:
> > On Tue, Feb 03, 2015 at 08:27:52PM +0100, Pali RohÃr wrote:
> > > On Tuesday 03 February 2015 20:18:59 Felipe Balbi wrote:
> > > > On Tue, Feb 03, 2015 at 05:17:28PM +0100, Pali RohÃr 
wrote:
> > > > > On Tuesday 03 February 2015 16:43:45 Felipe Balbi 
wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali RohÃr
> 
> wrote:
> > > > > > > On Tuesday 03 February 2015 00:15:19 Felipe Balbi
> 
> wrote:
> > > > > > > > f_phonet's ->set_alt() method will call
> > > > > > > > usb_ep_disable() potentially on an endpoint
> > > > > > > > which is already disabled. That's something the
> > > > > > > > gadget/function driver must guarantee that it's
> > > > > > > > always balanced.
> > > > > > > > 
> > > > > > > > In order to balance the calls, just make sure
> > > > > > > > the endpoint was enabled before by means of
> > > > > > > > checking the validity of driver_data.
> > > > > > > > 
> > > > > > > > Reported-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > > > > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > > > > > > > ---
> > > > > > > 
> > > > > > > Your patches cause that kernel does not print any
> > > > > > > error message to n900 screen anymore and reboot
> > > > > > > device in 10 seconds. I did not loaded any
> > > > > > > external modules.
> > > > > > 
> > > > > > > In qemu I see this crash in early boot:
> > > > > > alright, so n900's working fine. I'll wait until you
> > > > > > debug qemu a little more, thank you
> > > > > 
> > > > > NO! It does not working, see ^^^^. It break n900
> > > > > totally!
> > > > 
> > > > settle down a bit more. I don't have the HW you have and
> > > > things are working fine on boards I _do_ have, there's
> > > > not much more I can do to help without you doing your
> > > > homework. Debug a bit more and bring more information
> > > > as to what's going on, until then you're on your own.
> > > 
> > > And what more do you need? It crash on my n900 and also in
> > > qemu. I sent you kernel crash dump from qemu which
> > > introduced *your* patches. Before applying your patches
> > > there was no crash in early boot stage.
> > > 
> > > In current state I review all 3 patches as:
> > > 
> > > Rejected-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> > > [It breaks booting Nokia N900 device]
> > 
> > next step, figure why it's broken. Working just fine here on
> > AM335x which has the same musb IP.
> 
> Why is broken? That is easy. You send 3 patches which broke
> it.

Actually when I reverted only that patch which adds line:

pm_runtime_irq_safe(musb->controller)

then early boot crash disappeared.

But other two patches did not fixed support for external .ko 
gadget modules. State is same -- crash after modprobe.

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.