Re: [PATCH] x86: thinkpad_acpi.c: fix sparse warning

[Henrique de Moraes Holschuh]

On Thu, Feb 5, 2015, at 12:45, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
> 
> this patch fixes following sparse warning:
> 
> thinkpad_acpi.c:3459:11: warning: symbol 'adaptive_keyboard_modes' was
> not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>

> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1) and applies on top linux-next.
> 
>  drivers/platform/x86/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index c3d11fa..0e9262b 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3456,7 +3456,7 @@ enum ADAPTIVE_KEY_MODE {
>  	LAYFLAT_MODE
>  };
>  
> -const int adaptive_keyboard_modes[] = {
> +static const int adaptive_keyboard_modes[] = {
>  	HOME_MODE,
>  /*      WEB_BROWSER_MODE = 2,
>  	WEB_CONFERENCE_MODE = 3, */
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe
> platform-driver-x86" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/