Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task

[Eric Dumazet]

On Thu, 2015-02-05 at 16:36 +0100, Miroslav Urbanek wrote:
> flow_cache_flush_task references a structure member flow_cache_gc_work
> where it should reference flow_cache_flush_task instead.
> 
> Kernel panic occurs on kernels using IPsec during XFRM garbage
> collection. The garbage collection interval can be shortened using the
> following sysctl settings:
> 
> net.ipv4.xfrm4_gc_thresh=4
> net.ipv6.xfrm6_gc_thresh=4
> 
> With the default settings, our productions servers crash approximately
> once a week. With the settings above, they crash immediately.
> 
> Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware")
> Reported-by: TomÃÅ CharvÃt <tc@xxxxxxxxxx>
> Tested-by: Jan Hejl <jh@xxxxxxxxxx>
> Signed-off-by: Miroslav Urbanek <mu@xxxxxxxxxxxxxxxxxxx>
> ---

Nice catch !

Ok, but you do not need to cc so many people/lists

netdev is fine, and we usually CC patch author, just in case.

Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/