Re: [RFC][PATCH 1/7] trace: fix the glob match in __unregister_ftrace_function_probe()

[Al Viro]

On Thu, Feb 05, 2015 at 03:43:36PM -0500, Steven Rostedt wrote:
> Can you make search = NULL instead of glob at the start of the
> function. That is:
> 
> 	if (!glob || strcmp(glob, "*") == 0 || !strlen(glob))
> 		search = NULL;

Umm...  If we do it that way, I'd rather initialized search with NULL
and inverted the test:
	if (glob && *glob && strcmp(glob, "*") != 0) {
		parse it and set search
	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/