Re: [PATCH 1/5] rcu,nohz: add state parameter to context_tracking_user_enter/exit

[Frederic Weisbecker]

On Fri, Feb 06, 2015 at 01:20:21PM -0500, Rik van Riel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 02/06/2015 12:22 PM, Frederic Weisbecker wrote:
> > On Thu, Feb 05, 2015 at 03:23:48PM -0500, riel@xxxxxxxxxx wrote:
> >> From: Rik van Riel <riel@xxxxxxxxxx>
> >> 
> >> Add the expected ctx_state as a parameter to
> >> context_tracking_user_enter and context_tracking_user_exit,
> >> allowing the same functions to not just track kernel <> user
> >> space switching, but also kernel <> guest transitions.
> >> 
> >> Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>
> > 
> > You should consider using guest_enter() and guest_exit() instead.
> > These are context tracking APIs too but specifically for guest.
> 
> What do you mean instead?  KVM already uses those.
> 
> I just wanted to avoid duplicating the code...

I mean you can call rcu_user APIs directly from guest_enter/exit.
You don't really need to call the context_tracking_user functions
since guest_enter/guest_exit already handle the vtime accounting.

> 
> - -- 
> All rights reversed
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> 
> iQEcBAEBAgAGBQJU1QXlAAoJEM553pKExN6D+l4H/1PPmFioxed9XyL+rJZf0XSt
> mATl5JcWGlNybL5c4Tnld/3FX5/vYwBXmgw2Rh5a84F+TJi8B+Hu2Uwetl6C6vUF
> EK2+ExJ1rla4lpiO3frxPDdfdOHJFw2bR0fhEb4GHqcN2ecfSdXtL4hKwFru5h5s
> IJ8dzNIW52vzqzmulkcvI1y+VkgQBwUXYbkiGyy/MPf4F0WvGC9g44eXHZNPRXoT
> V34/nMJCpFHlZ7FVuHqGGstmPjv19VUAYNhUkrlU8DOpZMKxT58Sb1CGLfwsGqvZ
> y0+pRca8eT+gX0vqg9YUBfoEBNy4MnHdQEwQ0EPZwPJkcQ3Leco3/1JLHyDogCg=
> =3AJV
> -----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/