Re: [PATCH 5/8] fbdev: ssd1307fb: Add module parameter bitsperpixel.

[Maxime Ripard]

On Fri, Feb 06, 2015 at 11:28:11PM +0100, niederp@xxxxxxxxxxxxxxxx wrote:
> From: Thomas Niederprüm <niederp@xxxxxxxxxxxxxxxx>
> 
> This patch adds a module parameter 'bitsperpixel' to adjust the colordepth
> of the framebuffer. All values >1 will result in memory map of the requested
> color depth. However only the MSB of each pixel will be sent to the device.
> The framebuffer identifies itself as a grayscale display with the specified
> depth.

I'm not sure this is the right thing to do.

The bits per pixel for this display is rightfully defined, used and
reported to the userspace, why would you want to change that?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature