Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables in if conditions.

From: Sergei Shtylyov
Date: Sun Feb 08 2015 - 06:20:13 EST


On 2/8/2015 12:55 AM, Bas Peters wrote:

As specified in the CodingStyle.

Signed-off-by: Bas Peters <baspeters93@xxxxxxxxx>
---
drivers/usb/core/hub.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 82983d9..9afe8b0 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -671,8 +671,8 @@ resubmit:
if (hub->quiescing)
return;

- if ((status = usb_submit_urb (hub->urb, GFP_ATOMIC)) != 0
- && status != -ENODEV && status != -EPERM)
+ status = usb_submit_urb (hub->urb, GFP_ATOMIC);

checkpatch.pl should also complain about space before (.

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/