Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message

[Rafael J. Wysocki]

On Saturday, February 07, 2015 01:24:36 PM Dan Carpenter wrote:
> Facts:
> 1) None of these four error messages will ever be printed.
>    http://lwn.net/Articles/627419/
> 2) These messages are a waste of RAM.

So this is what the changelog should be saying, not that it "fixes
checkpatch warnings".

checkpatch warnings in *existing* code are meaningless, unless they
uncover a *real* problem in it which quite arguably this one is.  But
in those cases patch changelogs should talk about the *real* problems
and they don't even need to mention checkpatch then as far as I'm
concerned.

Send this one with a better changelog and I'll apply it.


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/