Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c

[Dan Carpenter]

On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@xxxxxxxxx>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.

I don't understand what this means.

> 

1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.

regards,
dan carpenter 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/