Re: [PATCH 2/4 V2] dt-bindings: Add root properties for Raspberry Pi

From: Stephen Warren
Date: Mon Feb 09 2015 - 13:06:26 EST


On 01/19/2015 12:01 PM, Stefan Wahren wrote:
Hi Stephen,

Stephen Warren <swarren@xxxxxxxxxxxxx> hat am 19. Januar 2015 um 18:13
geschrieben:


On 01/19/2015 04:00 AM, Stefan Wahren wrote:
This patch adds root compatible properties for the following boards:
- Raspberry Pi Model A
- Raspberry Pi Model A+
- Raspberry Pi Model B
- Raspberry Pi Model B (no P5)
- Raspberry Pi Model B rev2
- Raspberry Pi Model B+
- Raspberry Pi Compute Module

Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>

This seems sane to me. One thing I should have asked: What compatible
values does the RPi Foundation's downstream for all these cases?

good point. Unfortunately my patches to linux-rpi-kernel are held back because
of too many recipients, so it's possible that someone complain later.

I have looked at chapter 3.1 in [1], but didn't find the any other variants than
B and B+:

Here, the presence or absence of the "-plus" is the significant thing, not the
"b" -- Model A's and A+'s will
use the "b" and "b-plus" variants, respectively.

Also in the newest branch [2]:

bcm2835-rpi-b.dts -> model = Raspberry Pi Model B
bcm2708-rpi-b.dts -> model = Raspberry Pi Model B
bcm2708-rpi-b-plus.dts -> model = Raspberry Pi Model B+

Sorry, i don't have any experience with the downstream kernel. So please correct
me if looked at the wrong places.

[1] -
https://github.com/raspberrypi/documentation/blob/master/configuration/device-tree.md
[2] - https://github.com/raspberrypi/linux/tree/rpi-3.18.y/

This all matches what I found. I think differentiating between A/B and A+/B+ makes sense, so the compatible values in your patch should be fine; I'll reply to v2 in just a minute.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/