Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

From: Robert Jarzmik
Date: Mon Feb 09 2015 - 14:56:27 EST


> + ffuart: uart@40100000 {
> + clocks = <&pxa2xx_clks CLK_FFUART>;
> + };
> +

After another thought about your "one line" node, I think this can be even
improved, so that :
- uart clocks are put into pxa2xx.dtsi instead of pxa27x.dtsi
- replace all pxa2xx_clks by clks
- let pxa27x.dtsi, pxa3xx.dtsi declare the clks label

This way we'll have :
- pxa2xx.dtsi
ffuart: uart@40100000 {
compatible = ...
...
clocks = <&clks CLK_FFUART>;
};
- pxa27x.dtsi
clks: pxa2xx_clks@41300004 {
compatible = "marvell,pxa270-clocks";
#clock-cells = <1>;
status = "okay";
};
- pxa3xx.dtsi
clks: pxa3xx_clks@41300004 {
compatible = "marvell,pxa300-clocks";
#clock-cells = <1>;
status = "okay";
};

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/