Re: [PATCH resend 5/6] toshiba_acpi: Add support to enable/disable USB 3

[Azael Avalos]

Hi Darren,

2015-02-09 21:55 GMT-07:00 Darren Hart <dvhart@xxxxxxxxxxxxx>:
> On Mon, Feb 09, 2015 at 09:46:07PM -0700, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-02-09 21:11 GMT-07:00 Darren Hart <dvhart@xxxxxxxxxxxxx>:
>> > On Mon, Feb 09, 2015 at 08:34:53PM -0700, Azael Avalos wrote:
>> >> Toshiba laptops that come with USB 3 ports have a feature that lets
>> >> them disable USB 3 functionality and act as a regular USB 2 port, and
>> >> thus, saving power.
>> >>
>> >> This patch adds support to that feature, by creating a sysfs entry
>> >> named "usb_three", acceptig only two parameters, 0 to disable the
>> >> USB 3 (acting as a USB 2) and 1 to enable it.
>> >>
>> >
>> > Similar question, does the system BIOS allow you to configure this setting? If
>> > so, what would be the value for enabling it in the OS directly?
>>
>> Yes.
>
> Yes it's available in the BIOS?

Yes, it is available in the BIOS, sorry for not making that clear.

>
>> A Toshiba provided app lets you configure all these parameters from Windows,
>> and so, I'm developing a similar app for this, a few clicks and your
>> settings are
>> changed on the next reboot :-)
>>
>
> And I understand now that independent of the BIOS question, Windows has a
> program to make these changes. Blech. Going to think on these overnight and get
> back to you.
>
> I'd welcome the thoughts of the previous maintainers as to whether we want to
> include these kinds of OS-parity changes in the kernel. I'm probably leaning
> toward taking them.

Just let me know as to send a refreshed set of patches.

>
> Matthew, Len, is there some kind of precedent I need to be aware of here?
>
> --
> Darren Hart
> Intel Open Source Technology Center

Cheers
Azael

-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/