Re: [PATCH] libata: fixup return type of wait_for_completion_timeout

[Tejun Heo]

On Tue, Feb 10, 2015 at 03:39:36AM -0500, Nicholas Mc Guire wrote:
> -	if (!rc) {
> +	if (irq_timeout == 0) {

Why == 0 tho?  This always bothers me.  To match this style, we'd use
!= 0 to test the other direction.  In what way is "if (ret != 0)"
better than "if (ret)"?  We're negating the two tests needlessly.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/