Re: [PATCH] rtc: s3c: Fix the duplicate clock control

From: Andrew Morton
Date: Tue Feb 10 2015 - 15:31:25 EST


On Tue, 10 Feb 2015 12:07:30 +0900 Chanwoo Choi <cw00.choi@xxxxxxxxxxx> wrote:

> This patch fixes the duplicate clock control and split out clock control
> function as s3c_rtc_enable_clk()/s3c_rtc_disable_clk() to simplify code.

"fixes"? This is a pretty big patch and it is poorly described.

Please provide a complete description of what is wrong with the
original code and how this patch alters it. Please be sure to describe
the user-visible effects of the bug.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/