Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs

From: Dmitry Torokhov
Date: Tue Feb 10 2015 - 17:11:16 EST


Hi Samuel,

On Fri, Jan 23, 2015 at 01:28:14PM +0100, Samuel Thibault wrote:
> This permits to reassign input LEDs to something else than keyboard "leds"
> state, by adding a trigger and a led for each input leds, the former being
> triggered by EV_LED events, and the latter being by default triggered by the
> former. The user can then make the LED use another trigger, including other LED
> triggers of the same keyboard.
>
> The hardware LEDs are now not actioned from the EV_LED event any more, but from
> the per-device LED layer.
>
> [ebroder@xxxxxxxxxxxx: Rebased to 3.2-rc1 or so, cleaned up some includes, and fixed some constants]
> [akpm@xxxxxxxxxxxxxxxxxxxx: remove unneeded `extern', fix comment layout]
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> Signed-off-by: Evan Broder <evan@xxxxxxxxxxx>
> Acked-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
> Signed-off-by: John Crispin <blogic@xxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changed in this version:
> - use drvdata instead of platform_data
> - dropped CONFIG_INPUT_LEDS option
> - compacted leds and triggers array allocation
> - handle registration failure

This did not make the first batch, but I will try to get it into the
2nd.

Pavel, have you tried this version?

Thanks!

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/