Re: [RFC] pstore-ram: remove superfluous memory size check

[Kiran Kumar]

On Tue, Feb 10, 2015 at 10:38 PM, Mark Salyzyn <salyzyn@xxxxxxxxxxx> wrote:
>
> Please refer to '[PATCH v2 2/5] pstore: remove superfluous memory size check'

Cool,thanks for pointing.
Regards,
Kiran

>
> Sincerely -- Mark Salyzyn
>
> On 02/10/2015 02:26 AM, Kiran Raparthy wrote:
>>
>> From: Mark Salyzyn <salyzyn@xxxxxxxxxx>
>>
>> pstore-ram: remove superfluous memory size check
>>
>> All previous checks will fail with error if memory size
>> is not sufficient to register a zone, so this legacy
>> check has become redundant.
>>
>> Cc: Anton Vorontsov <anton@xxxxxxxxxx>
>> Cc: Colin Cross <ccross@xxxxxxxxxxx>
>> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>> Cc: Tony Luck <tony.luck@xxxxxxxxx>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Signed-off-by: Mark Salyzyn <salyzyn@xxxxxxxxxxx>
>> [Kiran: Added Context]
>> Signed-off-by: Kiran Raparthy <kumarsharma.r@xxxxxxxxx>
>>
>> ---
>> This is one of the number of patches from the Android AOSP common.git tree,
>> which is used on Android devices. I wanted to submit it for review
>> to see if it should go upstream.
>> [PATCH v2 2/5] pstore: remove superfluous memory size check
>>
>>   fs/pstore/ram.c | 9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index 8613e5b..34ed8f8 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -474,14 +474,6 @@ static int ramoops_probe(struct platform_device *pdev)
>>         if (err)
>>                 goto fail_init_fprz;
>>   -     if (!cxt->przs && !cxt->cprz && !cxt->fprz) {
>> -               pr_err("memory size too small, minimum is %zu\n",
>> -                       cxt->console_size + cxt->record_size +
>> -                       cxt->ftrace_size);
>> -               err = -EINVAL;
>> -               goto fail_cnt;
>> -       }
>> -
>>         cxt->pstore.data = cxt;
>>         /*
>>          * Console can handle any buffer size, so prefer LOG_LINE_MAX. If we
>> @@ -525,7 +517,6 @@ fail_buf:
>>         kfree(cxt->pstore.buf);
>>   fail_clear:
>>         cxt->pstore.bufsize = 0;
>> -fail_cnt:
>>         kfree(cxt->fprz);
>>   fail_init_fprz:
>>         kfree(cxt->cprz);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/