Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type

From: Ivan Khoronzhuk
Date: Wed Feb 11 2015 - 05:10:33 EST



On 02/11/2015 11:53 AM, Ard Biesheuvel wrote:
On 11 February 2015 at 17:46, Ivan Khoronzhuk
<ivan.khoronzhuk@xxxxxxxxxx> wrote:
According to SMBIOSv3 specification the length of DMI table can be
up to 32bits wide. So use appropriate type to avoid overflow.

It's obvious that dmi_num theoretically can be more than u16 also,
so it's can be changed to u32 or at least it's better to use int
instead of u16, but on that moment I cannot imagine dmi structure
count more than 65535 and it can require changing type of vars that
work with it. So I didn't correct it.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxxxxxx>
Acked-by: Ard Biesheuvel <ard@xxxxxxxxxx>

This should get a cc stable as well.


Pay attention that this patch has to be applied with patch 1/3.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/