Re: [PATCH 1/2] [media] am437x: VIDEO_AM437X_VPFE should depend on HAS_DMA

[Lad, Prabhakar]

On Thu, Feb 12, 2015 at 2:11 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> If NO_DMA=y:
>
>     warning: (VIDEO_AM437X_VPFE && VIDEO_DM365_VPFE && VIDEO_DT3155 && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
>
>     drivers/media/v4l2-core/videobuf2-dma-contig.c: In function âvb2_dc_mmapâ:
>     drivers/media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function âdma_mmap_coherentâ
>     drivers/media/v4l2-core/videobuf2-dma-contig.c: In function âvb2_dc_get_base_sgtâ:
>     drivers/media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function âdma_get_sgtableâ
>
> VIDEO_AM437X_VPFE selects VIDEOBUF2_DMA_CONTIG, which bypasses its
> dependency on HAS_DMA.  Make VIDEO_AM437X_VPFE depend on HAS_DMA to fix
> this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>

Regards,
--Prabhakar Lad

> ---
>  drivers/media/platform/am437x/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/am437x/Kconfig b/drivers/media/platform/am437x/Kconfig
> index 7b023a76e32ebabc..42d9c186710a6423 100644
> --- a/drivers/media/platform/am437x/Kconfig
> +++ b/drivers/media/platform/am437x/Kconfig
> @@ -1,6 +1,6 @@
>  config VIDEO_AM437X_VPFE
>         tristate "TI AM437x VPFE video capture driver"
> -       depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> +       depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
>         depends on SOC_AM43XX || COMPILE_TEST
>         select VIDEOBUF2_DMA_CONTIG
>         help
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/