Re: [GIT PULL] Backing device changes for 3.20

[Stephen Rothwell]

Hi All,

On Thu, 12 Feb 2015 14:05:00 -0800 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Feb 12, 2015 at 12:38 PM, Jens Axboe <axboe@xxxxxx> wrote:
> >
> > This pull request contains a cleanup of how the backing device is
> > handled, in preparation for a rework of the life time rules. In this
> > part, the most important change is to split the unrelated nommu mmap
> > flags from it, but also removing a backing_dev_info pointer from the
> > address_space (and inode), and a cleanup of other various minor bits.
> 
> Ugh, so this has a semantic conflict with the NFS client, that has
> this particular code:
> 
>         if (!cinfo->dreq) {
>                 inc_zone_page_state(req->wb_page, NR_UNSTABLE_NFS);
> -               inc_bdi_stat(page_file_mapping(req->wb_page)->backing_dev_info,
> +
> inc_bdi_stat(inode_to_bdi(page_file_mapping(req->wb_page)->host),
>                              BDI_RECLAIMABLE);
>                 __mark_inode_dirty(req->wb_context->dentry->d_inode,
>                                    I_DIRTY_DATASYNC);
>         }
> 
> duplicated several times, and now one more time in the new
> fs/nfs/flexfilelayout/flexfilelayout.c file.

Sometime I wonder why I bother pointing these things out in
linux-next :-(  Ah, well.

(Trond did mention it in his pull request, but it wasn't a problem
then.)

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgp0i1pTfEBYN.pgp
Description: OpenPGP digital signature