Re: [PATCH 1/1] Staging: dgnc: dgnc_tty: code style improvements

[tolga ceylan]

On 02/12/2015 10:20 PM, Joe Perches wrote:
> On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
> > On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > > That looks kind of uglier than before.  Please run your patch throught
> > > scripts/checkpatch.pl --strict.
> []
> > Running with --strict helped, but now I'm also getting warnings for
> > camel case usage.
>
> You can use --strict --ignore=camelcase
>
> > If I try to fix camel case, then
> > the patch will get much larger spanning many dgnc_* files. I can
> > proceed with this if you think it is valuable/acceptable.
>
> I suggest not.

Just noticed this warning in all dgnc_* files:

 *	NOTE TO LINUX KERNEL HACKERS:  DO NOT REFORMAT THIS CODE!
 *
 *	This is shared code between Digi's CVS archive and the
 *	Linux Kernel sources.
 *	Changing the source just for reformatting needlessly breaks
 *	our CVS diff history.
 *
 *	Send any bug fixes/changes to:  Eng.Linux at digi dot com.
 *	Thank you.

Seems unusual. Also get_maintainers.pl does not return any digi dot com addresses.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/