Re: [PATCH] fs: nfsd:xdr4.h: add missing conditional group CONFIG_NFSD_V3

From: Guenter Roeck
Date: Fri Feb 13 2015 - 14:18:50 EST


On 02/13/2015 09:33 AM, J. Bruce Fields wrote:
[...]

Result is that every build with NFS configured but not NSFv3 is
now broken.

Fortunately a v2-only server would be pretty unusual these days.

I don't know, maybe this?

--b.

commit 535c381153631af3bc708a97e267a2a6a86ee030
Author: J. Bruce Fields <bfields@xxxxxxxxxx>
Date: Fri Feb 13 12:27:39 2015 -0500

nfsd4: fix v3-less build

Includes of pnfs.h in export.c and fcntl.c also bring in xdr4.h, which
won't build without CONFIG_NFSD_V3, breaking non-V3 builds. Ifdef-out
most of pnfs.h in that case.

Reported-by: Bas Peters <baspeters93@xxxxxxxxx>
Reported-by: Jim Davis <jim.epost@xxxxxxxxx>
Fixes: 9cf514ccfac "nfsd: implement pNFS operations"
Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>

Passes all my build and runtime tests.

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/