Re: [PATCH RFC v3 0/7] epoll: Introduce new syscalls, epoll_ctl_batch and epoll_pwait1

From: Fam Zheng
Date: Sun Feb 15 2015 - 20:03:47 EST


On Sun, 02/15 15:00, Jonathan Corbet wrote:
> On Fri, 13 Feb 2015 17:03:56 +0800
> Fam Zheng <famz@xxxxxxxxxx> wrote:
>
> > SYNOPSIS
> >
> > #include <sys/epoll.h>
> >
> > int epoll_pwait1(int epfd, int flags,
> > struct epoll_event *events,
> > int maxevents,
> > struct epoll_wait_params *params);
>
> Quick, possibly dumb question: might it make sense to also pass in
> sizeof(struct epoll_wait_params)? That way, when somebody wants to add
> another parameter in the future, the kernel can tell which version is in
> use and they won't have to do an epoll_pwait2()?
>

Flags can be used for that, if the change is not radically different.

Fam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/