Re: [PATCH 1/2] virtio_pci_modern: type-safe io accessors

[Rusty Russell]

Rusty Russell <rusty@xxxxxxxxxxxxxxx> writes:

> "Michael S. Tsirkin" <mst@xxxxxxxxxx> writes:
>> The spec is very clear on this:
>>
>> 4.1.3.1 Driver Requirements: PCI Device Layout
>>
>> The driver MUST access each field using the ânaturalâ access method,
>> i.e. 32-bit accesses for 32-bit fields, 16-bit accesses for 16-bit
>> fields and 8-bit accesses for 8-bit fields.
>>
>> Add type-safe wrappers to prevent access with incorrect width.
>
> Applied both (for *next* merge window).

... and fixed this:

>> +static inline void vp_iowrite32(u32 value, u32 __iomem *addr)
>> +{
>> +	iowrite16(value, addr);
>> +}

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/