Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver

[Lee Jones]

On Wed, 04 Feb 2015, Chanwoo Choi wrote:
> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
> > This patch adds MAX77843 core/irq driver to support PMIC,
> > MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
> > LED and Haptic device.
> > 
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>
> > Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx>
> > ---
> >  drivers/mfd/Kconfig                  |   14 ++
> >  drivers/mfd/Makefile                 |    1 +
> >  drivers/mfd/max77843.c               |  245 +++++++++++++++++++
> >  include/linux/mfd/max77843-private.h |  441 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 701 insertions(+)
> >  create mode 100644 drivers/mfd/max77843.c
> >  create mode 100644 include/linux/mfd/max77843-private.h

<LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>

> Looks good to me.
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

Chanwoo,

If you're not going to make any comments, either put the Reviewed-by
at the top, or better still, snip out all of the bumph in the middle.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/