Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"

[Alexander Gordeev]

On Tue, Feb 10, 2015 at 09:51:20AM -0500, Tejun Heo wrote:
> Hello,
> 
> On Tue, Feb 10, 2015 at 08:57:46AM +0100, Stefan Bader wrote:
> > On 09.02.2015 20:54, Sander Eikelenboom wrote:
> > > Hi.
> > > 
> > > In 3.19 the device name associates with IRQ's for ahci controllers operating
> > > with a single IRQ changed from "ahci?" to "<BDF>", was this intentional ?
> > > 
> > > It's probably commit 18dcf433f3ded61eb140a55e7048ec2fef79e723 (or another one
> > > in that series). 
> > 
> > Oh, looking at that commit that might make sense. In
> > ahci_host_activate_single_irq it now uses dev_driver_name instead of dev_name as
> > it did before (from ata_host_activate).  The description sounds like before the
> > driver is registered this will return the bus. And registering an interrupt
> > would likely be before the driver is fully registered... But you probably saw
> > that, too. Whether that really was intentional is still the question. :)
> 
> Urgh... Alexander, can you please send a patch to fix up the names?

The problem dates back to commit 4f37b50 ("libata: Use dev_name() for
request_irq() to distinguish devices"). If the commit is considered valid
then <BDF> still might be legitimate as well. Not sure what is the best
approach here.

> Thanks.
> 
> -- 
> tejun

-- 
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/