Re: [PATCH 7/8] x86,fpu: use disable_task_lazy_fpu_restore helper

[Oleg Nesterov]

On 02/17, Borislav Petkov wrote:
>
> On Fri, Feb 06, 2015 at 03:02:04PM -0500, riel@xxxxxxxxxx wrote:
> > From: Rik van Riel <riel@xxxxxxxxxx>
> >
> > Replace magic assignments of fpu.last_cpu = ~0 with more explicit
> > disable_task_lazy_fpu_restore calls.
> >
> > This also fixes the lazy FPU restore disabling in drop_fpu, which
> > only really works when !use_eager_fpu().  This is fine for now,
> > because fpu_lazy_restore() is only used when !use_eager_fpu()
> > currently, but we may want to expand that.
>
> Sorry, I can't follow here. The only non-trivial change below is in
> arch_dup_task_struct(). Please clarify.

I guess Rik forgot to update the changelog ;)

Initial version of this patch played with drop_fpu() as well, this part
was removed after discussion. So I guess the last sentence in the changelog
should go away too.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/