Re: [PATCH 1/2] sched: Move __task_rq_{, un}lock() to kernel/sched/sched.h

From: Kirill Tkhai
Date: Tue Feb 17 2015 - 06:20:25 EST


Ð ÐÑ, 17/02/2015 Ð 12:11 +0100, Peter Zijlstra ÐÐÑÐÑ:
> On Tue, Feb 17, 2015 at 01:46:51PM +0300, Kirill Tkhai wrote:
> >
> > Place it in sched.h, because dl_task_timer() needs it.
> > Also remove lockdep check, which is not fit to this
> > function.
>
> No, that lockdep check is valid for all current sites.

Sure, but dl_task_timer() do not lock pi_lock. I wanted to delete
"again:" loop in it to simplify second patch.

We can do not touch __task_rq_lock(), and add smp_rmb() in "again:"
loop in second patch instead of this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/