Re: [PATCH 03/45] headers_install.sh: enhance error handling

[Michal Marek]

On 2015-02-17 00:05, Mikko Rapeli wrote:
> Exit with error if using undefined variables or if any sub command fails
> with error return value. unidef needs special handling since but this can
> be done without the trap. Enables exaniming intermediate files if some
> commands failed.

The intermediate files are removed by your patch as well, aren't they?
Actually, I don't see any change in behavior after your patch.


> Signed-off-by: Mikko Rapeli <mikko.rapeli@xxxxxx>
> ---
>  scripts/headers_install.sh | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh
> index fdebd66..072f7d3 100755
> --- a/scripts/headers_install.sh
> +++ b/scripts/headers_install.sh
> @@ -1,4 +1,7 @@
>  #!/bin/sh
> +set -e
> +set -u
> +#set -x

The commented-out statement should be removed.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/