Re: [PATCH] drivers/vmw_vmci: Show correct get_user_pages_fast upon err

[Greg Kroah-Hartman]

On Tue, Feb 17, 2015 at 01:57:34PM -0800, Davidlohr Bueso wrote:
> As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
> we no longer call get_user_pages(), thus update the warning.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx>
> ---
>  drivers/misc/vmw_vmci/vmci_queue_pair.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index 35f19a6..1d80c56 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -737,7 +737,8 @@ static int qp_host_get_user_memory(u64 produce_uva,
>  				     produce_q->kernel_if->num_pages, 1,
>  				     produce_q->kernel_if->u.h.header_page);
>  	if (retval < produce_q->kernel_if->num_pages) {
> -		pr_warn("get_user_pages(produce) failed (retval=%d)", retval);
> +		pr_warn("get_user_pages_fast(produce) failed (retval=%d)",
> +			retval);

What can a user do with this message?  Shouldn't it be a debug message?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/