Re: [GIT PULL] Fix mcelog regression

From: Ingo Molnar
Date: Wed Feb 18 2015 - 01:42:07 EST



* Luck, Tony <tony.luck@xxxxxxxxx> wrote:

> Sorry for bypassing normal channels, but this looks like
> a trivial regression fix to me, but I'm getting pushback
> from my co-maintainer and from Ingo.
>
> 1. This used to work
> 2. Now it doesn't
> 3. People have complained
>
> Previous threads:
> https://lkml.org/lkml/2015/1/30/641
> https://lkml.org/lkml/2015/2/11/437

So this fix is perfectly OK to me. The primary thing I
objected to (which objection you did not quote!!), was the
initial approach, the ugly vendor-specific switch you
added:

https://lkml.org/lkml/2015/2/9/237

The latest replacement commit you added looks clean - and
/dev/mcelog is certainly a legacy we have to keep.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/