Re: [PATCH v4 4/4] phy: add phy-hi6220-usb
From: Felipe Balbi
Date: Wed Feb 18 2015 - 09:36:49 EST
On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote:
> Hi, Kishon
> On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote:
> >On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote:
> >>Add usb phy controller for hi6220 platform
> >>Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> >> drivers/phy/Kconfig | 9 ++
> >> drivers/phy/Makefile | 1 +
> >> drivers/phy/phy-hi6220-usb.c | 306
> >> 3 files changed, 316 insertions(+)
> >> create mode 100644 drivers/phy/phy-hi6220-usb.c
> >why is this driver in drivers/phy when it doesn't use the generic PHY
> >framework at all?
> Balbi recommended "new drivers only on drivers/phy/", including usb
but it should use the API too. It's not only about a directory, you need
to use the new API.
> So Move drivers/usb/phy/phy-hi6220-usb.c to
> drivers/phy/phy-hi6220-usb.c, required by Balbi.
you're reading what I stated the way you like.
Description: Digital signature