Re: [PATCH] [media] soc-camera: Remove bogus devm_kfree() in soc_of_bind()

From: Sergei Shtylyov
Date: Wed Feb 18 2015 - 12:59:07 EST


On 02/18/2015 07:32 PM, Geert Uytterhoeven wrote:

Unlike scan_async_group(), soc_of_bind() doesn't allocate its
soc_camera_async_client structure using devm_kzalloc(), but has it
embedded inside the soc_of_info structure. Hence on failure, it must
not free it using devm_kfree(), as this will cause a warning, and may
cause slab corruption:


Fixes: 1ddc6a6caa94e1e1 ("[media] soc_camera: add support for dt binding soc_camera drivers")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Triggered with shmobile-defconfig on r8a7791/koelsch.
drivers/media/platform/soc_camera/soc_camera.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
index cee7b56f84049944..d8a072fe46035821 100644
--- a/drivers/media/platform/soc_camera/soc_camera.c
+++ b/drivers/media/platform/soc_camera/soc_camera.c
@@ -1665,7 +1665,6 @@ eclkreg:
- devm_kfree(ici->, sasc);

Perhaps Ben meant 'info' ISO 'sasc'? This way it would make more sense.

dev_err(ici->, "group probe failed: %d\n", ret);

return ret;

WBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at