Re: [PATCH v2 6/7] x86, mm: Support huge I/O mappings on x86

[Ingo Molnar]

* Toshi Kani <toshi.kani@xxxxxx> wrote:

> This patch implements huge I/O mapping capability interfaces on x86.

> +#ifdef CONFIG_HUGE_IOMAP
> +#ifdef CONFIG_X86_64
> +#define IOREMAP_MAX_ORDER       (PUD_SHIFT)
> +#else
> +#define IOREMAP_MAX_ORDER       (PMD_SHIFT)
> +#endif
> +#endif  /* CONFIG_HUGE_IOMAP */

> +#ifdef CONFIG_HUGE_IOMAP

Hm, so why is there a Kconfig option for this? It just 
complicates things.

For example the kernel already defaults to mapping itself 
with as large mappings as possible, without a Kconfig entry 
for it. There's no reason to make this configurable - and 
quite a bit of complexity in the patches comes from this 
configurability.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/