Re: [PATCH] x86/intel/quark: fix simple_return.cocci warnings

From: Bryan O'Donoghue
Date: Thu Feb 19 2015 - 06:02:27 EST

On 19/02/15 10:33, Ingo Molnar wrote:

Feedback at review was that it's more consistent with the
code that comes before.

But that feedback makes very little sense. In C we don't
ever want to write:

if (ret)
return ret;

return 0;

Because we can return the fine value straight away:

return ret;

regardless of what comes before.


Just trying to accommodate as much feedback from people as possible.

I'm fine with the change and I'll let Andy argue the counter-point if he wants to.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at