Re: [PATCH 1/2] regmap: Add range check in _regmap_raw_read()

From: Mark Brown
Date: Thu Feb 19 2015 - 07:22:42 EST

On Thu, Feb 19, 2015 at 11:04:39AM +0000, Srinivas Kandagatla wrote:
> On 19/02/15 10:27, Mark Brown wrote:

> >readability. A cheaper check for just max_register would be less
> >concerning but it feels like we're trying to paper over a symptom with
> >this rather than fix a problem.

> Yes, just checking max_register would solve the issue for me, I think I over
> done the patch.. I will resend with just max_register check.

I'm still not happy with that, it still seems like we're just papering
over some other problem here which we should understand before we do
anything else. Why are we generating out of bounds accesses in the
first place?

Attachment: signature.asc
Description: Digital signature