Re: [PATCH RFC] Update kernel math-emu code from current glibc soft-fp

From: David Miller
Date: Thu Feb 19 2015 - 14:10:35 EST


From: Joseph Myers <joseph@xxxxxxxxxxxxxxxx>
Date: Thu, 19 Feb 2015 18:40:34 +0000

> On Thu, 19 Feb 2015, David Miller wrote:
>
>> From: Joseph Myers <joseph@xxxxxxxxxxxxxxxx>
>> Date: Fri, 6 Feb 2015 17:25:29 +0000
>>
>> > * On SPARC, comparisons now use raw unpacking (this should not in fact
>> > change how the emulation behaves, just make it more efficient).
>>
>> I did a sparc64 test build and it failed like so:
...
> Please try this patch on top of the previous one. The way abort is
> redefined in the kernel code doesn't work for one place using it in an
> expression; this patch changes a comma expression to a statement
> expression. This didn't appear in my powerpc testing because the powerpc
> emulation never uses FP_FROM_INT; I'm not sure how Kaz's sh testing
> avoided the problem appearing there.
>
> diff --git a/include/math-emu/op-common.h b/include/math-emu/op-common.h
> index b9f5e1a..8c059c3 100644
> --- a/include/math-emu/op-common.h
> +++ b/include/math-emu/op-common.h

That fixes the build for 64-bit sparc, thanks Joseph.

I'll try to do some functional testing now.
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html