Re: [PATCH 1/1] nilfs2: fix potential memory overrun on inode

From: Andrew Morton
Date: Fri Feb 20 2015 - 21:01:40 EST


On Sat, 21 Feb 2015 10:13:28 +0900 (JST) Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx> wrote:

> I've got a warning from 0day kernel testing backend:
>
> fs/nilfs2/btree.c: In function 'nilfs_btree_root_broken':
> >> fs/nilfs2/btree.c:394:3: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'ino_t' [-Wformat=]
> pr_crit("NILFS: bad btree root (inode number=%lu): level = %d,
> flags = 0x%x, nchildren = %d\n",
> ^
>
> This is output for s390 arch since ino_t doesn't mean "unsigned long"
> in s390.

alpha uses uint for ino_t as well.

It seems a bit pointless - neither arch uses ino_t in ./arch/ code. I
suspect both could switch to ulong, which would make the world a
slightly better place.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/